Re: [PATCH 1/5] Add test-script for git-merge porcelain

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 23, 2007, 00:51 UTC
Message-ID: <7vwsuidx1a.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1190421186-21784-2-git-send-email-hjemli@gmail.com>

Lars Hjemli <hjemli@gmail.com> writes:

> This test-script tries to excercise the porcelainish aspects of git-merge.

It does exercise; no need for "tries to" ;-).

Show 14 quoted lines

> +test_expect_success 'verify merge result' '
> +	echo "
> +1 X
> +2
> +3
> +4
> +5
> +6
> +7
> +8
> +9
> +" > result.1 &&
> +	cmp -s file result.1
> +'

Unless there is a compelling reason otherwise, I'd prefer tests with a test vector like this to be spelled like this:

	diff -u result.1 file

That is, compare to show the difference actual output might have from the expected result. It's easier to spot the difference when you later break things this way.

Show 6 quoted lines

> +test_expect_success 'merge c1 with c2' '
> +	git reset --hard c1 &&
> +	git merge c2 &&
> +	test "$c1" = "$(git rev-parse HEAD^1)" &&
> +	test "$c2" = "$(git rev-parse HEAD^2)"
> +'

We might also want to test:

 - the index is merged;

 - the working tree matches the index;

 - the merge message (e.g. "git show -s --pretty=format:%s
   HEAD") is as expected;

Otherwise I think it is a good idea to add these tests.

By the way, I think squash_message() leaves a wrong message template for an Octopus, which might be worth fixing.