Re: [PATCH] git-stash: Display help message if git-stash is run with wrong sub-commands

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 3, 2007, 02:48 UTC
Message-ID: <7vwsrwqysf.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <e66701d40712021834h64bf8d0y14f0e222d0f9a617@mail.gmail.com>

"Kevin Leung" <kevinlsk@gmail.com> writes:

Show 5 quoted lines

> The current git-stash behaviour is very error prone to typos. For example,
> if you typed "git-stash llist", git-stash would think that you wanted to
> save to a stash named "llist", but in fact, you meant "git-stash list".
>
> Signed-off-by: Kevin Leung <kevinlsk@gmail.com>

Thanks.  Looks good.  except...

Show 8 quoted lines

> @@ -195,6 +195,10 @@ show)
>         shift
>         show_stash "$@"
>         ;;
> +save)
> +       shift
> +       save_stash "$@" && git-reset --hard
> +       ;;

... this should be "$*" as it was originally spelled.

Save this script in foo.sh and run "foo.sh a b c" to see what I mean.

#!/bin/sh

foo () {
	msg="$1"
	echo "Foo here <$1>"
}

foo "$@" foo "$*"