Re: [PATCH] git-pull: don't complain about branch merge config if only fetching tags
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 27, 2007, 10:39 UTC
- Message-ID
- <7vwsr0ifqi.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071227093016.18337.qmail@e6d9fb481b7087.315fe32.mid.smarden.org>
Gerrit Pape <pape@smarden.org> writes:
>> I've seen this patch on this list in the past, but isn't "git >> pull -t" a user-error? > > If so, we shouldn't advertise the -t switch in the git-pull(1) manpage.
Perhaps. Patches are welcomed as always.
> As it stands, I'd understand 'git pull -t' as 'fetch _all_ tags and > branch heads and merge according to the configuration'.
Yeah, but that would mean that the current error message needs to be kept, as that is the logical conclusion of "merge according to the configuration". Which is not so nice.
Perhaps using the same logic as your patch to detect the case of "pull --tags and nothing else" case, and exit with non-zero saying "you probably meant fetch --tags" would be a sane compromise? I dunno.