Re: [PATCH] Fix sed syntax in t7502-commit for OSX

From: Junio C Hamano <gitster@pobox.com>
Date: May 15, 2008, 08:37 UTC
Message-ID: <7vwslwgdyi.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1210817948-72280-1-git-send-email-git-dev@marzelpan.de>

Marcel Koeppen <git-dev@marzelpan.de> writes:

Show 20 quoted lines

> The OSX version of sed interprets the command as argument to the -i option.
>
> Signed-off-by: Marcel Koeppen <git-dev@marzelpan.de>
> ---
>  t/t7502-commit.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
> index 018060c..9a43104 100755
> --- a/t/t7502-commit.sh
> +++ b/t/t7502-commit.sh
> @@ -166,7 +166,7 @@ test_expect_success 'author different from committer' '
>  	test_cmp expect actual
>  '
>  
> -sed -i '$d' expect
> +sed -i -e '$d' expect
>  echo "# Committer:
>  #" >> expect
>  unset GIT_COMMITTER_EMAIL

Two comments and a half.

This patch does not make things worse, so I do not have much against it.

However, "sed -i $cmd" is also used in templates/hooks--prepare-commit-msg and you would want to fix it as well.

But more importantly, as we are serious about portability, we should not be using "sed -i" which is not even in POSIX to begin with. Can we rewrite these places without using the in-place extension?