Re: [PATCH] Make it clear that push can take multiple refspecs

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 29, 2008, 23:20 UTC
Message-ID: <7vwsj49t27.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080729231338.GA30717@toroid.org>

Abhijit Menon-Sen <ams@toroid.org> writes:

Show 17 quoted lines

> At 2008-07-29 15:06:57 -0700, gitster@pobox.com wrote:
>>
>> If you saw the question asked many times in the real world, that
>> would be a good indication that this patch falls into the "helpful"
>> category, not "noise". Will queue.
>
> Thanks.
>
> You may find the appended patch less noisy still. I certainly like being
> able to get rid of the "any number of..." sentence; and I also think the
> example is clearer, though I merged it into an existing one.
> ...
> -<refspec>::
> -	The canonical format of a <refspec> parameter is
> +<refspec>...::
> +	The canonical format of each <refspec> parameter is
>  	`+?<src>:<dst>`; that is, an optional plus `+`, followed

After re-reading this, prompted by your comment about "both synopsis syntax and regex in the same sentence, I actually do not see a problem with the original one. The synopsis talks about the ability for you to specify zero or more of whatever is called <refspec>, and here we define what _A_ refspec is.

Somehow I thought the issue was that we said "<refspec>...::" in the heading of the description without saying zero-or-more, but that is not the case here.