git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Improve portability: Avoid SS constant as it is already defined

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 27, 2008, 18:56 UTC
Message-ID
<7vwsi2p9qk.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1219858743-4476-3-git-send-email-sn_@gmx.net>
David Soria Parra <sn_@gmx.net> writes:
Show 5 quoted lines
> From: David Soria Parra <dsp@php.net>
>
> Constants that have the names of CPU registers are already defined
> in OpenSolaris's sys/regset.h. This causes a warning as we try to
> (re)define SS in ctype.c. So we just use another name.

I do not mind this _particular_ workaround per-se, but I have to wonder what happens the next time some random other platform has "SP" defined in a random header file.

First of all, why are you including <sys/regset.h>? We certainly don't include from any of our header or source files. And second of all, why is the indirect inclusion of that header file by some standard header file we do include cause the namespace to get poluted with "SS" symbol?

Previous: David Soria ParraNext: Junio C Hamano
Message 4 of 9 in “Improve portability for OpenSolaris”
  1. 0/2 Improve portability for OpenSolarisDavid Soria Parra, Aug 27, 2008
  2. 1/2 Improvate portability: Display pid_t's always as longDavid Soria Parra, Aug 27, 2008
  3. 2/2 Improve portability: Avoid SS constant as it is already definedDavid Soria Parra, Aug 27, 2008
  4. Junio C HamanoAug 27, 2008
  5. Junio C HamanoAug 27, 2008
  6. David Soria ParraAug 28, 2008
  7. Junio C HamanoAug 27, 2008
  8. David Soria ParraAug 30, 2008
  9. Junio C HamanoAug 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.