[RFC/H] "git diff --submodule" showing submodule work tree dirtiness

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 25, 2010, 18:05 UTC
Message-ID: <7vwrz62h7g.fsf_-_@alter.siamese.dyndns.org>
In-Reply-To: <4B5C547C.7000604@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

Show 16 quoted lines

> Right now "git diff --submodule" doesn't show the dirty status of a
> submodule at all (like it does when using it without that option and
> having paid the cost to get the necessary information). So IMHO something
> like the patch below should go into 1.7.0 to fix that. When applied the
> output looks like this:
>
> Submodule sub 3f35670..3f35670-dirty:
>
> which is now consistent with the output of "git diff" without that option:
>
> diff --git a/sub b/sub
> --- a/sub
> +++ b/sub
> @@ -1 +1 @@
> -Subproject commit 3f356705649b5d566d97ff843cf193359229a453
> +Subproject commit 3f356705649b5d566d97ff843cf193359229a453-dirty

I think this is sensible; I queued it to 'pu' to give chance to submodule users comment on it, but I am inclined to say it should be part of 1.7.0 for consistency.