git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] configure: Allow GIT_ARG_SET_PATH to handle --without-PROGRAM

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 1, 2010, 21:14 UTC
Message-ID
<7vwrywu08v.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1264990505-29578-2-git-send-email-bwalton@artsci.utoronto.ca>
Ben Walton <bwalton@artsci.utoronto.ca> writes:
Show 12 quoted lines
> Add an optional second argument to both GIT_ARG_SET_PATH and
> GIT_CONF_APPEND_PATH such that any value of the second argument will
> enable configure to set NO_$PROGRAM in addition to an empty
> $PROGRAM_PATH.  This is initially useful for allowing configure to
> disable the use of python, as the remote helper code has nothing
> leveraging it yet.
>
> The Makefile already recognizes NO_PYTHON, but configure provided no
> way to set it appropriately.
>
> Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
> ---
Interesting.

I noticed that even without this patch we seem to honor --without-tcltk just fine and wondered why. It turns out that we already do the right thing when TCLTK_PATH is empty to set NO_TCLTK in our Makefile, but we at the same time have a long custom code in configure.ac to support tcltk.

Perhaps we can clean-up with-/without-tcltk part in configure.ac using this?

Previous: Ben WaltonNext: Ben Walton
Message 4 of 5 in “configure tweaks for NO_PYTHON”
  1. 0/2 configure tweaks for NO_PYTHONBen Walton, Feb 1, 2010
  2. 1/2 configure: Allow GIT_ARG_SET_PATH to handle --without-PROGRAMBen Walton, Feb 1, 2010
  3. 2/2 configure: Allow --without-pythonBen Walton, Feb 1, 2010
  4. Junio C HamanoFeb 1, 2010
  5. Ben WaltonFeb 1, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.