Re: [RFC/PATCHv2 1/2] Starting work on a man page for /etc/gitweb.conf (WIP)

From: Junio C Hamano <gitster@pobox.com>
Date: May 29, 2011, 20:37 UTC
Message-ID: <7vwrh9nsyr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1306698626-32402-2-git-send-email-jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 31 quoted lines

> diff --git a/gitweb/Makefile b/gitweb/Makefile
> index 0a6ac00..582e1b0 100644
> --- a/gitweb/Makefile
> +++ b/gitweb/Makefile
> @@ -112,6 +112,14 @@ endif
>  
>  GITWEB_FILES += static/git-logo.png static/git-favicon.png
>  
> +GITWEB_MAN5_TXT = gitweb.conf.txt
> +GITWEB_MAN_TXT = $(GITWEB_MAN1_TXT) $(GITWEB_MAN5_TXT) $(GITWEB_MAN7_TXT)
> +GITWEB_MAN = $(patsubst %.txt,%.1,$(GITWEB_MAN1_TXT)) \
> +             $(patsubst %.txt,%.5,$(GITWEB_MAN5_TXT)) \
> +             $(patsubst %.txt,%.7,$(GITWEB_MAN7_TXT))
> +GITWEB_HTML= $(patsubst %.txt,%.html,$(GITWEB_MAN_TXT))
> +GITWEB_DOC = $(GITWEB_MAN) $(GITWEB_HTML)
> +
>  GITWEB_REPLACE = \
>  	-e 's|++GIT_VERSION++|$(GIT_VERSION)|g' \
>  	-e 's|++GIT_BINDIR++|$(bindir)|g' \
> @@ -155,6 +163,11 @@ test-installed:
>  	GITWEB_TEST_INSTALLED='$(DESTDIR_SQ)$(gitwebdir_SQ)' \
>  		$(MAKE) -C ../t gitweb-test
>  
> +### Documentation
> +
> +doc:
> +	$(MAKE) -C ../Documentation $(GITWEB_DOC)
> +
>  ### Installation rules
>  
>  install: all

I am not sure if this target is needed or even desirable.

The only potential benefit this complexity and risk of these build procedure knowledge diverge what is in ../Documentation is to let you say "cd gitweb && make doc" and avoid building the rest of the documentation, but I personally do not find it necessary at all.

Aren't you making a mistake similar to the one that let instaweb have intimate and unnecessary knowledge of how to build gitweb, which you recently cleaned up?