Re: [BUG] `git stash drop --help` removes stash

From: Junio C Hamano <gitster@pobox.com>
Date: May 22, 2012, 17:58 UTC
Message-ID: <7vwr443xp3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <95877607-FED0-41C0-9F12-B91FE9DE7871@openforce.com>

Alexander Daniel <alexander.daniel@openforce.com> writes:

> SUMMARY
> `git stash drop --help` removes stash@{0}

Thanks.

Unfortunately there is no subcommand specific help text, so a quick fix would be along the lines of the attached patch.

The right fix would be to instead add support for subcommand specific help text. Such a change would tweak assert_stash_like and assert_stash_ref not to die when --help is given even if there is no stash (or an explicit command line argument did not name a stash), and then make all subcommand implementations in the script (e.g. find places where these two functions are called) notice that the user asked for --help and give subcommand specific help text from there.

 git-stash.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/git-stash.sh b/git-stash.sh
index 4e2c7f8..487e2b5 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -339,6 +339,9 @@ parse_flags_and_rev()
 			--index)
 				INDEX_OPTION=--index
 			;;
+			--help)
+				usage
+			;;
 			-*)
 				FLAGS="${FLAGS}${FLAGS:+ }$opt"
 			;;