Re: [PATCH v4.1 5/5] push: update remote tags only with force
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 20, 2012, 05:44 UTC
- Message-ID
- <7vwqxgsu98.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAEUsAPa9fiF9cuMqRHNsQSz_CsbbvdO-eGDS9HWW3MrAYZPA8w@mail.gmail.com>
Chris Rorvick <chris@rorvick.com> writes:
Show 12 quoted lines
> On Mon, Nov 19, 2012 at 2:23 PM, Junio C Hamano <gitster@pobox.com> wrote: > > Yeah, this was one of a few stupid mistakes. Previously I used > 'forwardable' throughout, but that is awkward except in the last > commit since until then everything is allowed to fast-forward and the > flag is only used to output tag-specific advice. But inverting the > meaning of the flag is dumb, and I didn't even do it right. > > But, as I think you're suggesting, it probably makes more sense to use > a flag that prevents fast-forwarding when set. So maybe > "not_forwardable", or "is_a_tag" => "not_forwardable" if you think the > renaming is a good idea.
Yeah, calling it not-forwardable from the beginning would be a sensible approach, I would think.
Thanks.