Re: [PATCH] Fix typo in remote set-head usage
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 26, 2012, 18:16 UTC
- Message-ID
- <7vwqx8rzzf.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1353851019-27254-1-git-send-email-apelisse@gmail.com>
Antoine Pelisse <apelisse@gmail.com> writes:
Show 5 quoted lines
> parenthesis are not matching in `builtin_remote_sethead_usage` > as a square bracket is closing something never opened. > --- > This will also break all translation files, should I also send a patch > to update them ?
"git grep -A2 -e 'remote set-head <name>' po/" tells me that we already have both the correct variant and the broken one, and they are both translated ;-) so I do not think we have much to worry about the i18n fallout in this case, but thanks anyway for thinking about it.
You would need to sign off your patch, but otherwise looks good to me.
Thanks.
Show 22 quoted lines
>
> Cheers,
> Antoine Pelisse
>
> builtin/remote.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/remote.c b/builtin/remote.c
> index a5a4b23..937484d 100644
> --- a/builtin/remote.c
> +++ b/builtin/remote.c
> @@ -39,7 +39,7 @@ static const char * const builtin_remote_rm_usage[] = {
> };
>
> static const char * const builtin_remote_sethead_usage[] = {
> - N_("git remote set-head <name> (-a | -d | <branch>])"),
> + N_("git remote set-head <name> (-a | -d | <branch>)"),
> NULL
> };
>
> --
> 1.7.9.5