Re: jn/config-ignore-inaccessible (Re: What's cooking in git.git (Apr 2013, #10; Mon, 29))

From: Junio C Hamano <gitster@pobox.com>
Date: May 5, 2013, 03:55 UTC
Message-ID: <7vwqreull0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130504201414.GA2420@elie.Belkin>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 23 quoted lines

> Thomas Rast wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>
>>> * jn/config-ignore-inaccessible (2013-04-15) 1 commit
>>>  - config: allow inaccessible configuration under $HOME
>>>
>>>  When $HOME is misconfigured to point at an unreadable directory, we
>>>  used to complain and die. This loosens the check.
>>>
>>>  I do not think we agreed that this is a good idea, though.
>>
>> As a data point: yesterday on IRC, two users complained that they each
>> had this problem.
>>
>>   http://colabti.org/irclogger/irclogger_log/git?date=2013-05-03#l3022
>>   http://colabti.org/irclogger/irclogger_log/git?date=2013-05-03#l3111
>
> I think the approach taken in the patch above is a good one.  If
> /etc/gitconfig contains important configuration, it is still not
> ignored, errors other than permissions reading ~/.gitconfig are
> still fatal, and permissions errors accessing ~/.gitconfig are no
> longer fatal because they are expected as something very common
> in normal setups.

OK. Let's cook it in 'next' for a while and then decide what to do post 1.8.3; I am perfectly fine with making it graduate to 'master' immediately after 1.8.3 if everybody thinks this is a good idea.