Re: [RFC/PATCH] patch-ids: check modified paths before calculating diff

From: Junio C Hamano <gitster@pobox.com>
Date: May 20, 2013, 04:46 UTC
Message-ID: <7vwqquw958.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130519193612.GH3362@elie.Belkin>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 12 quoted lines

>> @@ -64,6 +199,13 @@ static struct patch_id *add_commit(struct commit *commit,
>>  	unsigned char sha1[20];
>>  	int pos;
>>  
>> +	if (no_add) {
>> +		if (collect_touched_paths(commit, ids, 1) < 0)
>> +			return NULL;
>
> Ah, so this is what the "searching" does.
>
> The existing "no_add" argument is very confusing (what does it mean to
> add a commit without adding?),

Such a mode of operation is usually called "dry-run", no?