Re: [PATCH] C implementation of the 'git' program.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Nov 11, 2005, 07:40 UTC
- Message-ID
- <7vveyzskdk.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <m3lkzv4qnz.fsf@harinath.blr.novell.com>
Raja R Harinath <rharinath@novell.com> writes:
Show 6 quoted lines
> This is bad, since it does the wrong thing for the correct way: > > make prefix=/usr > sudo make prefix=/usr install > > With your patch 'git' will be compiled as root.
You are correct.
We should allow building as user and installing as root, with the installation step _not_ touching the build directory at all. A good litmus test is that you should be able to build and install from a root-squashed NFS mounted working tree, without giving write permissions to NFS-nobody user (obviously you need to give read and search permissions).
Andreas?