Re: Use testlib to skip t3300-funny-names
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jan 6, 2006, 22:38 UTC
- Message-ID
- <7vvewxq8xg.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <81b0412b0601050353o6b96ed4fp2a6d24dd514cc9c2@mail.gmail.com>
Alex Riesen <raa.lkml@gmail.com> writes:
> The test cannot be run on cygwin anyway. > Corrected the error message to reflect the problem source.
I'd rather see the test actually try to create a funny-named testfile and see if it managed to create it, so that it can be skipped on non DOS systems that mounted DOS filesystem.
So instead I would do something like this:
---
diff --git a/t/t3300-funny-names.sh b/t/t3300-funny-names.sh index 6a85d67..b1a86db 100755 --- a/t/t3300-funny-names.sh +++ b/t/t3300-funny-names.sh @@ -9,9 +9,6 @@ This test tries pathnames with funny cha tree, index, and tree objects. ' -# since FAT/NTFS does not allow tabs in filenames, skip this test -test "$(uname -o 2>/dev/null)" = Cygwin && exit 0 - . ./test-lib.sh p0='no-funny' @@ -27,6 +24,12 @@ EOF cat >"$p1" "$p0" echo 'Foo Bar Baz' >"$p2" +test -f "$p1" && cmp "$p0" "$p1" || { + # since FAT/NTFS does not allow tabs in filenames, skip this test + say 'Your filesystem does not allow tabs in filenames, test skipped.' + test_done +} + echo 'just space no-funny' >expected test_expect_success 'git-ls-files no-funny' \