git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git 1.1.6.g4d44 make test FAILURE report

From
Junio C Hamano <junkio@cox.net>
Date
Feb 11, 2006, 02:17 UTC
Message-ID
<7vvevmtza4.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<43ED3FD3.7020005@gmail.com>
A Large Angry SCM <gitzilla@gmail.com> writes:
Show 6 quoted lines
> Also, git-var complains when used by an account with an empty gcos
> field; thereby, breaking all the non-C git commands even when the user
> is not committing.
>
> If the _intent_ was to force commiters and author names in commits,
> why was the test not placed only in commit-tree.c?

git-var was more or less intentional. Scripts such as git-applypatch, git-commit and git-tag use the command to grab COMMITTER_IDENT to generate sign-off line and tagger information when asked, and commit-tree.c changes alone would not catch them.

A user eventually would make commit so it may not be a too bad to _strongly_ encourage setting up these environment variables, by being nasty ;-). I agree it would be _very_ annoying until you either fix your gecos and/or environment.

Ideas welcome.
Previous: A Large Angry SCMNext: A Large Angry SCM
Message 4 of 10 in “Git 1.1.6.g4d44 make test FAILURE report”
  1. A Large Angry SCMFeb 10, 2006
  2. Junio C HamanoFeb 10, 2006
  3. A Large Angry SCMFeb 11, 2006
  4. Junio C HamanoFeb 11, 2006
  5. A Large Angry SCMFeb 11, 2006
  6. Junio C HamanoFeb 11, 2006
  7. Junio C HamanoFeb 11, 2006
  8. Teach repo-config the -l and --get-regexp optionsJohannes Schindelin, Feb 11, 2006
  9. Junio C HamanoFeb 12, 2006
  10. Add support for explicit type specifiers when calling git-repo-configPetr Baudis, Feb 12, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.