git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove possible segfault in http-fetch.

From
Junio C Hamano <junkio@cox.net>
Date
May 21, 2006, 07:49 UTC
Message-ID
<7vverzzukg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<BAYC1-PASMTP082397700A9527CC2F3786AEA40@CEZ.ICE>
Sean <seanlkml@sympatico.ca> writes:
Show 29 quoted lines
> Free the curl string lists after running http_cleanup to
> avoid an occasional segfault in the curl library.  Seems
> to only occur if the website returns a 405 error.
>...
> It comes with a big disclaimer because I don't really know the
> code in here all that well.  However gdb reports the segfault
> happens in a strncasecmp call, and seeing as we've released a
> bunch of strings prior to the call....
>
>  http-fetch.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/http-fetch.c b/http-fetch.c
> index 861644b..178f1ee 100644
> --- a/http-fetch.c
> +++ b/http-fetch.c
> @@ -1269,10 +1269,10 @@ int main(int argc, char **argv)
>  	if (pull(commit_id))
>  		rc = 1;
>  
> -	curl_slist_free_all(no_pragma_header);
> -
>  	http_cleanup();
>  
> +	curl_slist_free_all(no_pragma_header);
> +
>  	if (corrupt_object_found) {
>  		fprintf(stderr,
>  "Some loose object were found to be corrupt, but they might be just\n"

curl_easy_cleanup() which is called from http_cleanup() says it is safe to remove the strings _after_ you call that function, so I think the change makes sense -- it was apparently unsafe to free them before calling cleanup.

Knowing nothing about quirks in curl libraries, one thing that is mystery to me is that we slist_append() to other two lists (pragma_header and range_header) but we do not seem to ever free them. Another slist dav_headers is allocated and then freed inside a function, so that call-pattern seems well-formed.

Nick, care to help us out?
Previous: Florian WeimerNext: Nick Hengeveld
Message 4 of 6 in “Segfaults with USE_CURL_MULTI”
  1. Florian WeimerMay 20, 2006
  2. Remove possible segfault in http-fetch.Sean, May 20, 2006
  3. Florian WeimerMay 20, 2006
  4. Junio C HamanoMay 21, 2006
  5. Nick HengeveldMay 31, 2006
  6. Pavel RoskinMay 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.