Re: [PATCH 1/7] Remove ranges from switch statements.

From: Junio C Hamano <junkio@cox.net>
Date: Jun 18, 2006, 21:07 UTC
Message-ID: <7vveqyyxyj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1150643889264-git-send-email-octo@verplant.org>

Florian Forster <octo@verplant.org> writes:

Show 7 quoted lines

> -	switch (ch) {
> -	case '/': case '-': case '.':
> -	case 'A'...'Z':	case 'a'...'z':	case '0'...'9':
> +	if (((ch >= 'A') && (ch <= 'Z'))
> +			|| ((ch >= 'a') && (ch <= 'z'))
> +			|| ((ch >= '0') && (ch <= '9'))
> + ...

Sorry for bringing up an old topic again, but wouldn't people
agree that this is easier to read if it were written this way ;-)?
 
	if (	   (('A' <= ch) && (ch <= 'Z'))
        	|| (('a' <= ch) && (ch <= 'z'))
		|| (('0' <= ch) && (ch <= '9'))
	...