Re: [PATCH] gitweb: Paginate history output

From: Junio C Hamano <junkio@cox.net>
Date: Aug 22, 2006, 06:15 UTC
Message-ID: <7vveols3c7.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200608220053.10741.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 8 quoted lines

> @@ -1559,6 +1562,7 @@ sub git_history_body {
>  			next;
>  		}
>  
> +		#my $ref = defined $refs ? format_ref_marker($refs, $commit) : '';
>  		my $ref = format_ref_marker($refs, $commit);
>  
>  		if ($alternate) {

Do you want to change this or not?  Make up your mind.

> +		$paging_nav .= " &sdot; " .
> +			$cgi->a({-href => href(action=>"history", hash=>$hash, hash_base=>$hash_base,
> +			                       file_name=>$file_name, page=>$page-1),
> +			         -accesskey => "p", -title => "Alt-p"}, "prev");

This is something you inherited from the original and not your fault, but I am not sure if these -title entries are of good taste (we have corresponding "Alt-n" for "next"). Something more descriptive like "<Alt-p> for 100 newer changes", perhaps?

Also, "first", "prev" and "next" have always confused me. Maybe "latest", "older" and "newer" are better labels for them?

Is 100 a good default? It feels a bit unbalanced compared to the height of the default summary page with descriptions, 16 shortlog entries, 16 tags and 12 heads.