Re: [PATCH] git-repack: create new packs inside $PACKDIR, not cwd

From: Junio C Hamano <junkio@cox.net>
Date: Sep 4, 2006, 09:36 UTC
Message-ID: <7vveo4nfbg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060904090833.GF17042@admingilde.org>

Martin Waitz <tali@admingilde.org> writes:

Show 9 quoted lines

> hoi :)
>
> On Mon, Sep 04, 2006 at 05:42:32PM +1200, Martin Langhoff wrote:
>> Avoid failing when cwd is !writable by writing the
>> packfiles directly in the $PACKDIR.
>
> what if other GIT commands are being called while you repack?
> Wouldn't they try to use the new packs, even while they are not
> completely written?

Given that a new pack is created first by writing out .pack and then .idx, and that the using side ignores .pack without corresponding .idx, we are talking about very small window, but you are right.

Writing into $cwd was certainly a carelessness; we tend to use $GIT_DIR/ for this kind of thing.

-- 
VGER BF report: U 0.926108