Re: [PATCH] Removed memory leaks from interpolation table uses.

From: Junio C Hamano <junkio@cox.net>
Date: Sep 27, 2006, 19:42 UTC
Message-ID: <7vven99jur.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <E1GSc4w-0005cu-I3@jdl.com>

Jon Loeliger <jdl@jdl.com> writes:

> Junio,
>
> This is on top of my previous cleanup [PATCH Rev 3].

Thanks.

Show 7 quoted lines

> BTW, In that previous patch of mine, this line:
>
>         -	and %D for the absolute path of the named repository.	
>
> has trailing blanks in my patch that must be removed in order
> to apply it correctly to the HEAD of git.  The _previous_ patch
> clearly was (correctly) applied with --whitepace=strip!

Yes, I usually use --whitespace=strip. The only time I deliberately had to turn it off was to apply patches to diff output test vectors.

Hopefully the recent addition to "diff --color" output to highlight these potential whitespace errors would help spot them before making commits.