Re: [RFC] gitweb: Add committags support (take 2)

From: Junio C Hamano <junkio@cox.net>
Date: Dec 6, 2006, 19:11 UTC
Message-ID: <7vveko3km4.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200612061351.02712.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 8 quoted lines

> 1. Make it easier to have per repository gitweb configuration, for
>    example by having gitweb configuration file in GIT_DIR for a project,
>    "gitweb_conf.perl" by default:
>
>   our $GITWEB_REPO_CONFIG = $ENV{'GITWEB_REPO_CONFIG'} ||
>   	"++GITWEB_CONFIG++";
>   do "$projectroot/$project/$GITWEB_REPO_CONFIG"
>   	if -e "$projectroot/$project/$GITWEB_CONFIG";

I suspect site administrators would hesitate to have perl scripts in repositories that could run arbitrary things as their "side effects".

Show 6 quoted lines

> 2. Put the configuration in config file, using/like %features support.
>    For example gitweb.committags.<committag name> would hold parameters
>    for <committag>. Committags sequence would be given by sequence of
>    entries in config file. Comittags without options would have sole
>    variable entry (which I think is equivalent to being bool variable
>    and having 1 or 'yes' as value).

I think gitweb.* in $GIT_DIR/config and a config reader in Perl are very sensible things to do, and you would need the config reader eventually anyway. The longer we postpone it, the more we risk the temptation to pollute $GIT_DIR/ with the likes of "description", "owner", and "homepage", and I do not think we want to make this worse.

> What do you think about it? Junio? Pasky?

If you are asking Pasky, you should CC him, I think. I added him to the CC list.