Re: git completely non-operational w/ curl 7.16.0

From: Junio C Hamano <junkio@cox.net>
Date: Jan 4, 2007, 06:45 UTC
Message-ID: <7vvejnmgrh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070104023150.GA31151@codeblau.de>

felix-git@fefe.de writes:

> I'm using git 1.4.4.3 on x86_64-linux with curl 7.16.0, glibc 2.5, gcc
> 4.1.1 and binutils 2.17.  All of these are as far as I know the current
> release versions.

This may be related to a bug in cURL 7.16.0, which is reported to be fixed in their current CVS version:

	http://curl.haxx.se/mail/archive-2006-12/0085.html

In the meantime, we have a workaround for this particular problem the above URL mentions since last week.

Please try "master" (or anything later than v1.5.0-rc0) to see if it still breaks for you.

The fix also should apply cleanly on top of 1.4.4.3.

-- >8 -- [PATCH] Work around http-fetch built with cURL 7.16.0

It appears that curl_easy_duphandle() from libcurl 7.16.0 returns a curl session handle which fails GOOD_MULTI_HANDLE() check in curl_multi_add_handle(). This causes fetch_ref() to fail because start_active_slot() cannot start the request.

For now, check for 7.16.0 to work this issue around.

Signed-off-by: Junio C Hamano <junkio@cox.net>

diff --git a/http.h b/http.h
index 6e12e41..324fcf4 100644
--- a/http.h
+++ b/http.h
@@ -18,7 +18,7 @@
 #define curl_global_init(a) do { /* nothing */ } while(0)
 #endif
 
-#if LIBCURL_VERSION_NUM < 0x070c04
+#if (LIBCURL_VERSION_NUM < 0x070c04) || (LIBCURL_VERSION_NUM == 0x071000)
 #define NO_CURL_EASY_DUPHANDLE
 #endif