Re: [PATCH] Documentation: clarify glossary definition of "reachable"

From: Junio C Hamano <junkio@cox.net>
Date: Jan 8, 2007, 01:44 UTC
Message-ID: <7vvejiz40u.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070108002839.GF18009@fieldses.org>

"J. Bruce Fields" <bfields@fieldses.org> writes:

Show 17 quoted lines

> Clarify glossary definition of "reachable" (what chain?)
>
> Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
> ---
>  Documentation/glossary.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/glossary.txt b/Documentation/glossary.txt
> index 7c1a659..5886fa7 100644
> --- a/Documentation/glossary.txt
> +++ b/Documentation/glossary.txt
> @@ -236,7 +236,7 @@ push::
>  
>  reachable::
>  	An object is reachable from a ref/commit/tree/tag, if there is a
> -	chain leading from the latter to the former.
> +	chain of parent commits leading from the latter to the former.

That is better but the description is too commit centric.

        The set of reachable objects from a tag is the tag
        itself and the set of reachable objects from the object
        it tags.  The set of reachable objects from a commit is
        the commit itself, and the set of reachable objects from
        its parents and its tree.  The set of reachable objects
        from a tree is the tree itself, and the set of reachable
        objects from the trees and blobs contained within it.
        The set of reachable objects from a blob is the blob
        itself.

And that description is too verbose and too technical (definition being recursive). Better rewording?