Re: [PATCH] defaults for where to merge from (take 3)

From: Junio C Hamano <junkio@cox.net>
Date: Mar 1, 2007, 10:27 UTC
Message-ID: <7vvehls1h9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0703010212w5367c8cek51f22e9098f8e22f@mail.gmail.com>

"Alex Riesen" <raa.lkml@gmail.com> writes:

Show 7 quoted lines

> On 3/1/07, Paolo Bonzini <paolo.bonzini@gmail.com> wrote:
>> > Actually, how about making the default configurable _AND_ have
>> > the --no-track option (for scripting)?
>>
>> Fine by me.  And also --track in case you want to try it out.  ;-)
>
> Ack. Thanks!

Having both --track and --no-track options is a nice touch to give scripts dependable behaviour. Well done.

>> Patch attached.  --remove-section will go in a separate patch.
>
> Still think it is a very dangerous operation.

I am going to bed now, but I would appreciate if the list could help Paolo:

 (1) with styles.  I have only given a cursory look at the
     patch, but I think people already know what I like and not
     like.

 (2) by reviewing the changes to the .config writer.  That
     traditionally has been one of the more fragile parts of the
     system, and I am reluctant to look at it.

 (3) come up with a version that is easier-to-apply (including
     sending an in-line patch).

I would just feel better to see a patch like this, which is a significant improvement to the system, to be properly signed-off by the submitter.

Also it would be nice if you guys can fight it out about the default value for 'tracked'. I do not think _I_ can defend the position to create these tracking configurations by default to old timers (especially the ones that do not follow the git mailing list), as I am not convinced (not yet, anyway).