Re: [PATCH] Fix tests when using bash_completion

From: Junio C Hamano <junkio@cox.net>
Date: Apr 23, 2007, 21:56 UTC
Message-ID: <7vvefmdab8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0704232235280.7626@beast.quantumfyre.co.uk>

Julian Phillips <julian@quantumfyre.co.uk> writes:

> (I'm not the only one who thinks CDPATH is ick am I? :S)

CDPATH is Ok as long as it stays as an interactive shell variable.

Sadly, if you google for "CDPATH environment", you would see many many hits. That variable is not meant to be used as an environment variable.

Something like this in .bashrc is acceptable:

	case "$PS1" in
        '')
        	;; # do not do useless thing for noninteractive
	?*)
        	CDPATH=my:favorite:path
                . $HOME/.bash-completion
		;;
	esac

but people usually are way too careless than that and export CDPATH to the environment, and that is where breakages start.