Re: [PATCH] Documentation: format-patch has no --mbox option

From: Junio C Hamano <junkio@cox.net>
Date: May 15, 2007, 00:20 UTC
Message-ID: <7vveevkkdc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7v8xbrlzqk.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 14 quoted lines

> Frank Lichtenheld <frank@lichtenheld.de> writes:
>
>> git-applymbox and git-mailinfo refer to a --mbox
>> option of git-format-patch. But there is no such
>> option AFAICT. mbox output can produced with
>> format-patch --stdout.
>>
>> This patch only replaces --mbox with --stdout.
>> Some further explanation and/or format-patch
>> arguments (e.g. -k) might be needed.
>
> I would agree.  "Reads single mbox with one or more patches in
> it, without munging the subject line" is what it really does, so
> we obviously mean "--stdout -k >mbox" here.

Come to think of it, "no munging of Subject lines" is orthogonal to the number of patches in a file, so it should say that the option corresponds to -k in format-patch, I think.

So, I think we can just do s/--mbox/-k/, instead of s/--mbox/--stdout/ which is what you did.