Re: [PATCH] gitweb: handle non UTF-8 text

From: Junio C Hamano <junkio@cox.net>
Date: Jun 2, 2007, 22:15 UTC
Message-ID: <7vvee6nguh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200706012305.41183.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 17 quoted lines

> On Tue, 29 May 2007, Martin Koegler wrote:
> ...
>> But I agree, that there should be the possibilty to choose a the
>> fallback encoding.
>
> I think for the beginning it would be enough to have
>
>   # assume this charset if line contains non-UTF-8 characters
>   our $fallback_encoding = "latin1";
>
> or something like that (perhaps different wording in the comment,
> perhaps different name of the variable) in the gitweb.perl for your
> idea to be accepted.
>
> That, and using to_utf8 (as before e3ad95a8) and not my_decode_utf8
> as subroutine name. If only it would be possible to avoid I think
> quote costly "eval {....}" invocation...

Except that I had an impression that block form of "eval" (as opposed to "parse and evaluate string" kind) was not costly at all.

Please make it so.

I'll read the other parts of your message again -- I might have further comments.