Re: [PATCH] git-send-email: Add --threaded option

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2007, 05:21 UTC
Message-ID: <7vvedaq8eg.fsf@assigned-by-dhcp.pobox.com>
In-Reply-To: <11828981103069-git-send-email-aroben@apple.com>

Adam Roben <aroben@apple.com> writes:

Show 6 quoted lines

> The --threaded option controls whether the In-Reply-To header will be set on
> any emails sent. The current behavior is to always set this header, so this
> option is most useful in its negated form, --no-threaded. This behavior can
> also be controlled through the 'sendemail.threaded' config setting.
>
> Signed-off-by: Adam Roben <aroben@apple.com>

Thanks. I've always felt that send-email has too much built-in policy; I think this is a sensible change.

Show 8 quoted lines

> @@ -138,8 +141,8 @@ my (@to,@cc,@initial_cc,@bcclist,@xh,
>  	$initial_reply_to,$initial_subject,@files,$from,$compose,$time);
>  
>  # Behavior modification variables
> -my ($chain_reply_to, $quiet, $suppress_from, $no_signed_off_cc,
> -	$dry_run) = (1, 0, 0, 0, 0);
> +my ($threaded, $chain_reply_to, $quiet, $suppress_from, $no_signed_off_cc,
> +	$dry_run) = (1, 1, 0, 0, 0, 0);

While we are at it, you might want to make everything other than quiet and dry_run overridable the same way.