Re: [PATCH] git-am: Run git gc only once and not for every patch.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 5, 2008, 06:55 UTC
- Message-ID
- <7vve68ep78.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <7vmyrli73h.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> ... > I do not think moving "gc --auto" outside the loop hurts in > practice because you are not likely to be rebasing a truly huge > series every day, but cruft can accumulate during "git am" run > and the "gc --auto" inside loop was meant to clean them up. The > idea was taken from importers that run repack every once in a > while (e.g. cvsimport runs every 1k commits), but "gc --auto" > was designed to be much more lightweight than a full repack and > that was the reason it was placed in the loop without counting > "every N commits".
Having said all that, I'll take your patch as-is except that I'd drop the later part of the commit log message that explains Wine's practice.