Re: [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 27, 2008, 22:40 UTC
- Message-ID
- <7vvdzuo61b.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.LNX.1.00.0806271149580.19665@iabervon.org>
Daniel Barkalow <barkalow@iabervon.org> writes:
Show 15 quoted lines
> On Fri, 27 Jun 2008, Johannes Schindelin wrote:
>
>> After initializing the config in the newly-created repository, we
>> need to unset GIT_CONFIG so that the global configs are read again.
>
> This seems fine to me. OTOH, I'm not sure the environment variable should
> be needed in the first place; I think the config stuff should look in
> git_path("config") without it, and we set the git dir to the one we're
> initializing. So I think the use of the environment variable is just an
> artifact of how the shell script did it and how I was originally calling
> the init_db stuff.
>
> Just removing the "setenv()" line survives all of the tests for me, and I
> remember some of them failing before I'd gotten some sort of solution for
> the config stuff.Ok, I take that you are Ok with 2/2 but you have a better replacement patch coming for this 1/2?