Re: Minimum libCurl version for git
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 24, 2009, 07:35 UTC
- Message-ID
- <7vvdpz2x0v.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <e2b179460903230424v1c98d73ci1f41918807fb2d5c@mail.gmail.com>
Mike Ralphson <mike.ralphson@gmail.com> writes:
Show 16 quoted lines
> 2009/3/20 Junio C Hamano <gitster@pobox.com>: >> We can have these two macro definitions on our side >> >> #if curl older than 7.10.8 >> #define CURLINFO_RESPONSE_CODE CURLINFO_HTTP_CODE >> #endif >> >> #if curl older than 7.9.7 >> #define CURLOPT_READDATA CURLOPT_INFILE >> #endif >> >> for backward compatibility, while writing our code to the recent API by >> using CURLINFO_RESPONSE_CODE and CURLOPT_READDATA, and people with older >> curl would not have to suffer a bit. > > See? That's why they pay you the big maintainer-bucks... 8-)
The big maintainer-buck is called zero cents. I am only paid with the freedom to spend 20% of my day-job time on git [*1*].
In any case, "Write to the latest API, support older platforms with backward compatibility wrapper as necessary" is a good practice employed by many successful projects, including the kernel, and I think it would apply here nicely.
>> Mike, I'd say we declare 7.9.3 as the floor and go from there. That's >> your #3, I think. > > Short patch series to follow, though maybe not today.
Thanks.
[Footnote]
*1* ... which is still generous of my employer and NEC, given the current economic climate, but I wouldn't exactly call that "big bucks" ;-).