Re: [PATCH] Shift object enumeration out of upload-pack

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 8, 2009, 02:36 UTC
Message-ID: <7vvdn78n98.fsf@alter.siamese.dyndns.org>
In-Reply-To: <c77435a80906071834m1600d23dpb4a1b58c7a61361d@mail.gmail.com>

Nick Edelen <sirnot@gmail.com> writes:

> okie dokie.  is this good?

No.  The above line should be after "---".

> From: Nick Edelen <sirnot@gmail.com>
> Subject: [PATCH] Shift object enumeration out of upload-pack

And these two are not necessary, as you are not forwarding somebody else's mail nor sending from an account that you do not to be recorded as the author (i.e. your RFC2822 "From: " header is the same as this one).

> Offload object enumeration in upload-pack to pack-objects, but fall
> back on internal revision walker for shallow interaction.  Test t5530
> updated to reflect mechanism change.

Here, "to reflect mechanism change" is not quite a good enough description. Your explanation to Nico was much better.

> Signed-off-by: Nick Edelen <sirnot@gmail.com>
> Acked-by: Nicolas Pitre <nico@cam.org>

By the way, the proposed commit log message describes what the patch does (i.e. "shifts enumeration from one process to the other"), but does not answer more important question. Please say _why_ it is a good idea to do so in the message.

Thanks.