Re: [PATCH] push: Correctly initialize nonfastforward in do_push.

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 16, 2009, 18:15 UTC
Message-ID: <7vvdjizrgg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqfxamby33.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Short answer: trust me, without the patch, you get the non-fast
> forward (and valgrind tells you about conditional jump on
> uninitialized value), with, you don't ;-).

I understand valgrind one; I can trace the codepath with eyeballs without it, and that is why I said it looks correct to begin with.

My puzzlement was that the following in the log message did not seem to reproduce for me:

    ... where "git push ... nonexisting-branch" was complaining about
    non-fast forward.

I would be eventually writing an entry in the Release Notes about this fix, and I do not want to say:

    "git push $there no-such-ref" incorrectly said no-such-ref does not
    fast forward; fixed.

when I know that command line would produce something entirely different error.