Re: v1.7.0-rc0 shows lots of "unable to find <sha1>" on git-stash

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 30, 2010, 20:25 UTC
Message-ID: <7vvdejmjaj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v8wbfnyz9.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Please try this.

oops, but with this, too.

Show 11 quoted lines

> diff --git a/submodule.c b/submodule.c
> index ca0527f..8bd0a30 100644
> --- a/submodule.c
> +++ b/submodule.c
> ...
> @@ -142,7 +142,9 @@ int is_submodule_modified(const char *path)
>  	env[0] = strbuf_detach(&buf, NULL);
>  	strbuf_addf(&buf, "GIT_DIR=%s/.git", path);
>  	env[1] = strbuf_detach(&buf, NULL);
> -	env[2] = NULL;
> +	strbuf_addf(&buf, "GIT_INDEX_FILE=");

This should be:

	strbuf_addf(&buf, "GIT_INDEX_FILE");

Show 5 quoted lines

> +	env[2] = strbuf_detach(&buf, NULL);
> +	env[3] = NULL;
>  
>  	memset(&cp, 0, sizeof(cp));
>  	cp.argv = argv;