Re: [PATCH] shortlog: do not stall when there is no input

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 24, 2010, 19:31 UTC
Message-ID: <7vvddmmnvo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201002242020.27801.barra_cuda@katamail.com>

Michele Ballabio <barra_cuda@katamail.com> writes:

> A simple "git shortlog" outside of a git repository used to stall
> waiting for an input. Fix this by testing with isatty() before
> calling read_from_stdin().

I'd actually prefer doing what "git commit" does. Give a helpful hint that it is waiting for input from the standard input, but do read from standard input as the program is instructed to do.

That way people who drive the program with expect will not be broken ;-) but that is a minor point.