Re: [PATCH] remote add: add a --no-tags (-n) option

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2010, 18:13 UTC
Message-ID: <7vvdbnqpis.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100419135014.1077.28627.stgit@localhost.localdomain>

Samuel Tardieu <sam@rfc1149.net> writes:

Show 6 quoted lines

> @@ -116,6 +116,8 @@ static int add(int argc, const char **argv)
>  
>  	struct option options[] = {
>  		OPT_BOOLEAN('f', "fetch", &fetch, "fetch the remote branches"),
> +		OPT_BOOLEAN('n', "no-tags", &notags,
> +			"do not import remote tags when fetching"),

Any long-opt that begins with "no-" looks wrong, especially that will allow people to say "--no-no-tags". Perhaps something like this is necessary.

    { OPTION_BOOLEAN, 0, "tags", &tags, NULL, "fetch tags", PARSE_OPT_NOARG }

Or imitate whatever we do in builtin-fetch.c; although I suspect the default would be different in this command and "git fetch", so you may need to adjust for the difference a bit.