Re: [PATCH v3 3/3] New send-email option smtpserveroption.

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 6, 2010, 21:13 UTC
Message-ID: <7vvd6itw1c.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201009061223.59090.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 10 quoted lines

> On Mon, 6 Sep 2010, Junio C Hamano wrote:
> ...
>> And test if it is easy to arrange (otherwise I'll take a look myself, so
>> do not worry too much about it).
>
> Actually because *all* options use the same mechanism (%config_settings
> which is used in read_config, and GetOptions from Getopt::Long), it would
> be better to just test the mechanism, I think.
>
> But that is outside the scope of this patch...

I didn't mean a test that makes sure --sso=foo is parsed into @sso array; that would be a _mechanism_ test you alluded to, but I think we probably do not need such a test as long as we trust Getopt::Long().

What I meant was to make sure that the result is correctly propagated to the invocation of "exec($smtp_server, @sendmail_params)"; presumably the check will use a custom $smtp_server command that checks individual command line parameters. And that _is_ exactly within the scope of this change.