git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] apply: Recognize epoch timestamps with : in the timezone

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 13, 2010, 19:31 UTC
Message-ID
<7vvd55lwjl.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7v4ocpncli.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 9 quoted lines
> Neither the patch nor your suggestion makes much sense to me.  With the
> patch, the regexp is now
>
>     ^(1969-12-31|1970-01-01) <time>(\.0+)? ([-+][0-2][0-9]):?([0-5][0-9])
>
> so $3 is always 3 letters long (i.e. hour with sign), no?  IOW, zoneoffset
> is never divided by 100 by the original patch.
>
> What am I missing?

Well, I was missing that without ':' strtol() goes through to parse $3$4 as a single integer, and the division was done to discard the minute part and parse it again.

Calling strtol() twice only because some unusual input may have ':' there feels ugly, but now I understand why the patch is written that way, at least.

Previous: Junio C HamanoNext: Jonathan Nieder
Message 5 of 7 in “apply: Recognize epoch timestamps with : in the timezone”
  1. apply: Recognize epoch timestamps with : in the timezoneAnders Kaseorg, Sep 29, 2010
  2. Jonathan NiederSep 29, 2010
  3. Jonathan NiederSep 29, 2010
  4. Junio C HamanoOct 13, 2010
  5. Junio C HamanoOct 13, 2010
  6. Jonathan NiederOct 13, 2010
  7. Junio C HamanoOct 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.