Re: [PATCH] git-p4: Fix 'p4 opened' in git-p4 for names with spaces

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 14, 2010, 23:16 UTC
Message-ID: <7vvd2wq72l.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1292360165-26771-2-git-send-email-jerzy.kozera@gmail.com>

Jerzy Kozera <jerzy.kozera@gmail.com> writes:

Show 15 quoted lines

> Signed-off-by: Jerzy Kozera <jerzy.kozera@gmail.com>
> ---
>  contrib/fast-import/git-p4 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index 04ce7e3..a5297e7 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -144,7 +144,7 @@ def setP4ExecBit(file, mode):
>  def getP4OpenedType(file):
>      # Returns the perforce file type for the given file.
>  
> -    result = p4_read_pipe("opened %s" % file)
> +    result = p4_read_pipe("opened \"%s\"" % file)

Don't you need a lot more than that?  What if file has " or \ in it?