Re: [PATCH] Fix wrong xhtml option to highlight
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 24, 2011, 22:48 UTC
- Message-ID
- <7vvd1dlxza.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1295898298-9794-1-git-send-email-Jochen@herr-schmitt.de>
Jochen Schmitt <Jochen@herr-schmitt.de> writes:
Show 27 quoted lines
> ---
> Hallo,
>
> because I'm the maintainer of the highlight package in the
> Fedora Project I was notified, that highlight doesn't works
> properly with gitweb in BZ #672293.
>
> So I have create the following simple patch to solve the
> reported issue.
>
> Best Regards
>
> Jochen Schmitt
>
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 1025c2f..b662420 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3468,7 +3468,7 @@ sub run_highlighter {
> close $fd;
> open $fd, quote_command(git_cmd(), "cat-file", "blob", $hash)." | ".
> quote_command($highlight_bin).
> - " --xhtml --fragment --syntax $syntax |"
> + " -xhtml --fragment --syntax $syntax |"Curious.
Does the command take double-dash for the fragment and syntax options but a single dash for the xhtml option? Really...
A few top hits returned by Google for "highlight manual page" tells me otherwise.