Re: Bikeshedding advice on the ab/i18n-scripts series

From: Junio C Hamano <gitster@pobox.com>
Date: May 16, 2011, 21:40 UTC
Message-ID: <7vvcxajpda.fsf@alter.siamese.dyndns.org>
In-Reply-To: <BANLkTi=FLWFzMFG5DgQiaN9kYW3pozJ6HQ@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 15 quoted lines

> On Mon, May 16, 2011 at 23:26, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Ævar Arnfjörð Bjarmason wrote:
>>
>>> That would require us to start extracting strings from all "say"
>>> functions. The reason we have only "gettext" and "eval_gettext" is so
>>> xgettext can extract them.
>>
>> Isn't that what the xgettext -k parameter is for?
>
> I'm not saying we can't use xgettext to extract these things. I'm
> saying I don't think it's a good idea.
>
>     $ git --no-pager grep say git-submodule.sh
>     git-submodule.sh:                       say "$(eval_gettext
> "Entering '\$prefix\$path'")"

Oh, I didn't mean to say "we _must_ call that _say_".

The discussion suggested to me that we may want two variants, one that takes an incomplete single line and outputs a single complete line, and the other that takes whatever the caller gives and outputs the translated lines without further butchering the tail end. I missed that Jonathan already mentioned gettext_nl and that is fine as well, but if we use a function other than gettext I thought it would be better to use short and sweet name for common cases.