Re: gitweb showing slash r at the end of line

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 27, 2012, 23:15 UTC
Message-ID: <7vvcnwybxj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m3aa58eskw.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

Show 10 quoted lines

> Ondra Medek <xmedeko@gmail.com> writes:
>
>> we have gitweb running on Linux box. Some files have Windows line ending
>> (CRLF) end we do not use core.autcrlf translation. gitweb show the last \r
>> in the end of each line, which is annoying.
>
> Well, this "\r" allows to recognize when file with Windows line ending
> (CRLF) made it into repository... which usually is discouraged.  But
> if you allow this, I can understand that those "\r" at the end of
> every line can be annoying.

I think the right thing to do is:

 * If the repository data is _supposed_ to have CRLF endings (e.g. check
   with core.crlf or something), strip \r and do not show them.

 * Otherwise, i.e. if the repository data is supposed _not_ to have CRLF
   endings, do show these '\r'.  Annoyance here is a *feature* to remind
   the viewer that the contents needs _fixing_.

 * No other switches.