git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase: report invalid commit correctly

From
Junio C Hamano <gitster@pobox.com>
Date
May 30, 2012, 21:11 UTC
Message-ID
<7vvcjdxtlm.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1338395982-5448-1-git-send-email-kusmabite@gmail.com>
Erik Faye-Lund <kusmabite@gmail.com> writes:
Show 16 quoted lines
> In 9765b6a (rebase: align variable content, 2011-02-06), the code
> to error out was moved up one level. Unfortunately, one reference
> to a function parameter wasn't rewritten as it should, leading to
> the wrong parameter being errored on.
>
> This error was propagated by 71786f5 (rebase: factor out reference
> parsing, 2011-02-06) and merged in 78c6e0f (Merge branch
> 'mz/rebase', 2011-04-28).
>
> Correct this by reporting $onto_name istead.
>
> Reported-By: Manuela Hutter <manuelah@opera.com>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a proper patch, I guess.
Thanks.
Previous: Erik Faye-Lund
Message 5 of 5 in “calling git rebase with invalid onto-ref exits with wrong error message”
  1. Manuela HutterMay 30, 2012
  2. Erik Faye-LundMay 30, 2012
  3. Junio C HamanoMay 30, 2012
  4. rebase: report invalid commit correctlyErik Faye-Lund, May 30, 2012
  5. Junio C HamanoMay 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.