Re: Incorrect v1.7.10.4 tag on github?

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 15, 2012, 19:14 UTC
Message-ID: <7vvcis9ylx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120615182534.GB14843@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> On Fri, Jun 15, 2012 at 09:51:00AM -0700, Graham Ballantyne wrote:
>
>> I just downloaded the 1.7.10.4 tag from github. After compiling and
>> installing, git --version returns "git version 1.7.10.3". I think that
>> tag might be pointing to the wrong commit?
>
> Looks like 121f71f (Git 1.7.10.4, 2012-06-03) forgot to update DEF_VAR
> in GIT-VERSION-GEN. Operator error from the maintainer?

Thanks for noticing.

> It builds with the right version from the git repository (which runs
> git-describe and sees we are on the v1.7.10.4 tag), but exporting the
> tag's contents and building fails. I suspect that the git-1.7.10.4
> tarball on kernel.org would also have the same problem.

It builds correctly if you download the tarball from the official location in the [ANNOUNCE] message. This is because the build procedure for the official tarball does a bit more than just running "git archive-tar", which is what gitweb download interface does (namely, it adds the correct "version" file).