Re: Bug: problem with file named with dash character

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2012, 20:48 UTC
Message-ID: <7vvcic7a6t.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vzk7o7am5.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 20 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Junio C Hamano <gitster@pobox.com> writes:
>>>
>>>> Jeff King <peff@peff.net> writes:
>>>>
>>>>> but that code path should be fixed properly (with a use_stdin flag in
>>>>> the filespec).
>>>>
>>>> Yes, just as I said; I am finding more and more issues with the
>>>> no-index hack that I have been fixing a bit by bit since I send the
>>>> message you responded to.
>>>
>>> It is not ready yet, but here are a few patches WIP.
>>
>> And this is the second clean-up
>
> And this is the third one.

Some of the other breakages that comes from the "no-index" codepath that we may want to consider addressing I have found so far are:

 - We say on the "diff --git" header uglyness like "a/-", "b/-";
   likewise in the metainfo;

 - We show on the "index" header "0*" value for these entries, even
   though we should be able to compute it (after all we do so for
   files on disk in a non-git directory);

 - We still apply attributes and textconv as if we are dealing with
   a regular file "-" at the root level.