Re: [PATCH] Fallback on getpwuid if envar HOME is unset

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2012, 19:22 UTC
Message-ID: <7vvcgccaol.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAFFUb6XMGgG=6uUzd0Xs1TXWFbJhDpMz1FeFdC8jHqaRi8Y58A@mail.gmail.com>

Conley Owens <cco3@android.com> writes:

> Yes, that's the upstart I'm referring to.  This makes sense.  However, it's a
> confusing situation to run into.  Would a warning about an unset $HOME be
> appropriate?

Unsetting HOME is an easy way to skip what is in ~/.gitconfig when helping other people on this list, and I wouldn't mind such a warning while I knowingly unset it, I can imagine other helpful people may find such a warning irritating and complain "I know I do not have $HOME set, as I earlier explicitly did unset it myself!".

So, I am on the fence on this one, but because

 (1) no warning would mean upstart scripts writers need to be aware
     of lack of $HOME, but they need to be aware of it for reasons
     unrelated to Git anyway; and

 (2) a warning while trying vanilla Git behaviour to help others
     might be irritating, it is not an every day use anyway.

I do not think it matters either way in practice.