Re: [RFC] Support for HP NonStop

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2012, 21:50 UTC
Message-ID: <7vvcg8x8lo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <005701cd8239$1a828300$4f878900$@schmitz-digital.de>

"Joachim Schmitz" <jojo@schmitz-digital.de> writes:

Show 9 quoted lines

> Reminds me of a related issue: in compat/fnmatch/fnmatch.c there is this:
> #if HAVE_STRING_H || defined _LIBC
> # include <string.h>
> #else
> # include <strings.h>
> #endif
>
> There's no place where HAVE_STRING_H get set
> This looks wrong to me,...

This is because it is a borrowed file from glibc, and we try to minimize changes to such a file.

If you need HAVE_STRING_H to force inclusion of <string.h> on your platform, doing this:

>        COMPAT_CFLAGS += -DHAVE_STRING_H=1 # needed in compat/fnmatch/fnmatch.c

is perfectly the right thing to do.

> Do platforms exist without string.h?
> Maybe fnmatch.c should look like this instead?

We try to minimize changes to such a file we borrow from upstream; especially we do not do so lightly when we have to ask "do platforms exist?" Of course, they do---otherwise glibc folks wouldn't have written such a conditional.