git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-send-email: don't return undefined value in extract_valid_address()

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 20, 2012, 22:14 UTC
Message-ID
<7vvcczrkgi.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20121120204736.GA7039@shrek.podlesie.net>
Krzysztof Mazur <krzysiek@podlesie.net> writes:
> Yes, it's just to hide the warning, the error (warning in this case) it's
> already correctly generated:
>
> W: unable to extract a valid address from: x a.patch

But it is of no use if the message is sent out without the intended recipient, no? It is too late when you notice it.

> Maybe we should change it to an error?

At least, when we are not giving the "final sanity check [Y/n]?" prompt, I think the code should error out.

Previous: Krzysztof Mazur
Message 4 of 4 in “git-send-email: don't return undefined value in extract_valid_address()”
  1. git-send-email: don't return undefined value in extract_valid_address()Krzysztof Mazur, Nov 20, 2012
  2. Junio C HamanoNov 20, 2012
  3. Krzysztof MazurNov 20, 2012
  4. Junio C HamanoNov 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.